openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 27427 <27427@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 27427 2021-09-16 12:30:32 +00:00 committed by Gerrit Code Review
parent b5ca254796
commit 08d4eb2f1d
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
bef53bc2f63d85b7b8a85e4327db38065b78e9a6
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "84fcad19_db63ff46",
"filename": "validations_libs/cli/common.py",
"patchSetId": 2
},
"lineNbr": 105,
"author": {
"id": 27427
},
"writtenOn": "2021-09-16T12:30:32Z",
"side": 1,
"message": "If I read this correctly, we have made this function generic for use as extra vars or skip list.\n\nGood idea.\n\nBut... is there any scope for naming collision / race condition if operator passes _both_ extra-vars _and_ skip-list files?",
"revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "9e8c8f47_b193d796",