openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 32926 2021-07-21 15:24:02 +00:00 committed by Gerrit Code Review
parent 1f7358f7a8
commit 08f952f54a
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
9e3ee5f051544691ee12d25b869916f67d667be2 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "ab8452cd_f615c53b",
"filename": "validations_libs/utils.py",
"patchSetId": 3
},
"lineNbr": 93,
"author": {
"id": 32926
},
"writtenOn": "2021-07-21T15:24:02Z",
"side": 1,
"message": "I think this line is a bit superfluous.",
"revId": "9e3ee5f051544691ee12d25b869916f67d667be2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "962fc9c6_0a404001",
"filename": "validations_libs/utils.py",
"patchSetId": 3
},
"lineNbr": 187,
"author": {
"id": 32926
},
"writtenOn": "2021-07-21T15:24:02Z",
"side": 1,
"message": "s/should/must/",
"revId": "9e3ee5f051544691ee12d25b869916f67d667be2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "90b927d6_c4fb789b",
"filename": "validations_libs/utils.py",
"patchSetId": 3
},
"lineNbr": 491,
"author": {
"id": 32926
},
"writtenOn": "2021-07-21T15:24:02Z",
"side": 1,
"message": "I\u0027m thinking about the logic in these three methods. \nAll of them are performing same checks but in widely different forms. \n\nMaybe we should do something about it.",
"revId": "9e3ee5f051544691ee12d25b869916f67d667be2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}