Update patch set 51
Patch Set 51: Code-Review-1 (2 comments) There are some gaps in the test coverage of this patch. Most important in the validations_libs/cli/history.py and the validations_libs/ansible.py Patch-set: 51 Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
7a0d02e53b
commit
0c4f17eecf
|
@ -0,0 +1,38 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "127d956a_f13f8b26",
|
||||||
|
"filename": "validations_libs/ansible.py",
|
||||||
|
"patchSetId": 51
|
||||||
|
},
|
||||||
|
"lineNbr": 279,
|
||||||
|
"author": {
|
||||||
|
"id": 32926
|
||||||
|
},
|
||||||
|
"writtenOn": "2021-08-04T10:07:14Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Would it be possible to cover this method with tests?\nOne for normal run and another for IO exceptions would be enough.",
|
||||||
|
"revId": "250229138ae67d52624df009612273dbedf1f886",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "7faae376_f64c2fdd",
|
||||||
|
"filename": "validations_libs/ansible.py",
|
||||||
|
"patchSetId": 51
|
||||||
|
},
|
||||||
|
"lineNbr": 475,
|
||||||
|
"author": {
|
||||||
|
"id": 32926
|
||||||
|
},
|
||||||
|
"writtenOn": "2021-08-04T10:07:14Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "This branch also lacks test coverage.",
|
||||||
|
"revId": "250229138ae67d52624df009612273dbedf1f886",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": true
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue