Update patch set 3

Patch Set 3:

(1 comment)

Patch-set: 3
This commit is contained in:
Gerrit User 32926 2021-04-26 12:11:58 +00:00 committed by Gerrit Code Review
parent d36e2277c9
commit 10ed1d95a3
1 changed files with 24 additions and 0 deletions

View File

@ -22,6 +22,30 @@
"revId": "4138185e899650c42b73ec149f00d0ae167f614b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "e1daeb15_f06f2060",
"filename": "validations_libs/utils.py",
"patchSetId": 3
},
"lineNbr": 70,
"author": {
"id": 32926
},
"writtenOn": "2021-04-26T12:11:58Z",
"side": 1,
"message": "The constants.py checks only for existence. Permissions are determined here.\nSo when the folder exists, but isn\u0027t accessible, this will simply fail, and print out a nice exception message. \n\nBut it doesn\u0027t help the user beyond diagnostics. Now, instead of just saying what went wrong, it will try to put the logs in home folder, if the process owner has one, or in PWD, which is, as you noted, always set. \n\nAnd it will log an exception and warning, with both the original, and final path.\n\nThis way we will have logs dir under almost any circumstances and the customer will be notified of the issue. Not to mention the fact that it will simplify our diagnostics of future issues, as we will now know, where did the process attempt to make a logdir.",
"parentUuid": "8686859f_cbca6933",
"range": {
"startLine": 69,
"startChar": 8,
"endLine": 70,
"endChar": 42
},
"revId": "4138185e899650c42b73ec149f00d0ae167f614b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}