openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(3 comments)

Just minor adjustments on the logging messages, otherwise tests are conclusive!

Looks very good to me.

Patch-set: 10
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 11491 2021-06-10 09:21:53 +00:00 committed by Gerrit Code Review
parent 98ab7c6284
commit 197c11220c
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
f76f15dc90c9a85a700cd57b23af6f9a16169802 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "b9e330a0_9b2089d2",
"filename": "validations_libs/utils.py",
"patchSetId": 10
},
"lineNbr": 56,
"author": {
"id": 11491
},
"writtenOn": "2021-06-10T09:21:53Z",
"side": 1,
"message": "Could you please add a space after the period?\n\nI got this:\n\n Selected log directory \u0027/home/stack/validations\u0027 is inaccessible.Please check the access rights for: \u0027/home/stack/validations\u0027",
"revId": "f76f15dc90c9a85a700cd57b23af6f9a16169802",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "9b0c3731_193ad22f",
"filename": "validations_libs/utils.py",
"patchSetId": 10
},
"lineNbr": 73,
"author": {
"id": 11491
},
"writtenOn": "2021-06-10T09:21:53Z",
"side": 1,
"message": "Here too, please ;-)",
"revId": "f76f15dc90c9a85a700cd57b23af6f9a16169802",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b188026a_ffa83df9",
"filename": "validations_libs/utils.py",
"patchSetId": 10
},
"lineNbr": 124,
"author": {
"id": 11491
},
"writtenOn": "2021-06-10T09:21:53Z",
"side": 1,
"message": "Here too please.",
"revId": "f76f15dc90c9a85a700cd57b23af6f9a16169802",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}