Update patch set 1
Patch Set 1: (1 comment) Patch-set: 1 CC: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
parent
5f704d53d5
commit
1b353b519a
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "e70739b9_59a692c0",
|
||||
"filename": "validations_libs/cli/common.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 130,
|
||||
"author": {
|
||||
"id": 32926
|
||||
},
|
||||
"writtenOn": "2021-06-11T11:27:42Z",
|
||||
"side": 1,
|
||||
"message": "You can simplify this.\nIf the delay is set, by default, to a reasonable `float` value,\nthe conditional won\u0027t be needed. \n\nYou also don\u0027t need the type check.\n\nThe API will only be accessible by managed code, so you can handle it there\nor just convert by default. \nIt\u0027s virtually no delay, and if it fails it makes perfectly clear why.",
|
||||
"revId": "78cbdfcdb4eaf15c6b6298d562cfe4418cba6983",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue