openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(1 comment)

Just nitpicking otherwise looks good.

Patch-set: 13
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 11491 2021-07-29 09:49:36 +00:00 committed by Gerrit Code Review
parent d4338d0baf
commit 1be3c5c108
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
e63163bf6909c2545aa2ed270ae410aa88057621 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "587492d5_773e15be",
"filename": "validations_libs/validation_actions.py",
"patchSetId": 13
},
"lineNbr": 410,
"author": {
"id": 11491
},
"writtenOn": "2021-07-29T09:49:36Z",
"side": 1,
"message": "When running validation by name, I\u0027ve got this:\n\n ...\n Getting the [\u0027check-ram\u0027, \u0027check-cpu\u0027, \u0027512e\u0027] validation.\n Running the validations with Ansible.\n Gathered playbooks:\n -/usr/share/ansible/validation-playbooks/check-ram.yaml\n -/usr/share/ansible/validation-playbooks/check-cpu.yaml\n -/usr/share/ansible/validation-playbooks/512e.yaml\n ...\n\nI am nitpicking but it would be better to get this:\n\n self.log.debug((\n \u0027Running the validations with Ansible.\\n\u0027\n \u0027Gathered playbooks:\\n- {}\u0027).format(\n \u0027\\n- \u0027.join(playbooks)))\n\nin order to display the log like this:\n\n ...\n Getting the [\u0027check-ram\u0027, \u0027check-cpu\u0027, \u0027512e\u0027] validation.\n Running the validations with Ansible.\n Gathered playbooks:\n - /usr/share/ansible/validation-playbooks/check-ram.yaml\n - /usr/share/ansible/validation-playbooks/check-cpu.yaml\n - /usr/share/ansible/validation-playbooks/512e.yaml\n ...",
"revId": "e63163bf6909c2545aa2ed270ae410aa88057621",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}