From 1eee81d906f7902bc36db2f21e19fe1e159a86eb Mon Sep 17 00:00:00 2001 From: Jiri Podivin Date: Thu, 25 Nov 2021 13:28:15 +0100 Subject: [PATCH] Mocking 'open' to improve test isolation As a result of a minor oversight, the test execution could initiate a successful call to the 'open' and write in the storage. This patch addresses the issue. Signed-off-by: Jiri Podivin Change-Id: Iceb6df712b2ac0dc56aa86f465fd39cf308de2d7 --- validations_libs/tests/cli/test_run.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/validations_libs/tests/cli/test_run.py b/validations_libs/tests/cli/test_run.py index 2ef08121..66f17759 100644 --- a/validations_libs/tests/cli/test_run.py +++ b/validations_libs/tests/cli/test_run.py @@ -40,10 +40,11 @@ class TestRun(BaseCommand): parsed_args = self.check_parser(self.cmd, args, verifylist) self.assertRaises(RuntimeError, self.cmd.take_action, parsed_args) + @mock.patch('validations_libs.cli.common.open') @mock.patch('validations_libs.validation_actions.ValidationActions.' 'run_validations', return_value=copy.deepcopy(fakes.FAKE_SUCCESS_RUN)) - def test_run_command_success(self, mock_run): + def test_run_command_success(self, mock_run, mock_open): args = self._set_args(['--validation', 'foo']) verifylist = [('validation_name', ['foo'])]