openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(4 comments)

About the data collection part, I think it's worth adding examples of what they have to do or what they will have to see as results. Without example(s), procedures or commands, it could be confusing.

Patch-set: 7
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 11491 2021-08-04 21:24:25 +00:00 committed by Gerrit Code Review
parent 06c563a672
commit 41b782e97b
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
0999476e6d3caf0290a2ebf0e100502ed6cc1d9f Normal file
View File

@ -0,0 +1,72 @@
{
"comments": [
{
"key": {
"uuid": "464d7e05_276365c0",
"filename": "doc/source/debugging.rst",
"patchSetId": 7
},
"lineNbr": 23,
"author": {
"id": 11491
},
"writtenOn": "2021-08-04T21:24:25Z",
"side": 1,
"message": "s/minimumn/minimum/",
"revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "27e0677b_99ecfaff",
"filename": "doc/source/debugging.rst",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 11491
},
"writtenOn": "2021-08-04T21:24:25Z",
"side": 1,
"message": "s/paramaters/parameters/",
"revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "7024551a_ea64585a",
"filename": "doc/source/debugging.rst",
"patchSetId": 7
},
"lineNbr": 43,
"author": {
"id": 11491
},
"writtenOn": "2021-08-04T21:24:25Z",
"side": 1,
"message": "Those are global arguments and should be placed in the right place.\n\nIt\u0027s worth giving them an example:\n\n validation -vvv --debug [sub command] \n\nwdyt?",
"revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "4f02c3b4_26811abd",
"filename": "doc/source/debugging.rst",
"patchSetId": 7
},
"lineNbr": 46,
"author": {
"id": 11491
},
"writtenOn": "2021-08-04T21:24:25Z",
"side": 1,
"message": "which arguments? the global ones or the sub command ones?",
"revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}