Update patch set 3

Patch Set 3: Code-Review-1

(6 comments)

Patch-set: 3
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

4d1df7b0e75260c96164fd5a21347f5ce18c7a8b

@@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "82fd2835_555d4d82",
+        "filename": "validations_libs/cli/show.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 17,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-06-17T08:58:42Z",
+      "side": 0,
+      "message": "Add \n  \n   from cliff.lister import Lister",
+      "revId": "4d1df7b0e75260c96164fd5a21347f5ce18c7a8b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "3accca7b_851fd5e1",
+        "filename": "validations_libs/cli/show.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-06-17T08:58:42Z",
+      "side": 0,
+      "message": "Please let the ShowGroup class in cli/show.py. Change just the inheritance!\n\n   class ShowGroup(Lister):",
+      "revId": "4d1df7b0e75260c96164fd5a21347f5ce18c7a8b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "0cfb3707_8366360c",
+        "filename": "validations_libs/cli/show.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 66,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-06-17T08:58:42Z",
+      "side": 0,
+      "message": "Those two arguments are useless here and especially the --validation-dir.\n\nThe groups.yaml is delivered by the openstack-tripleo-validations in one well-known place and this should remain an internal feature.\n\nPlease, remove them.",
+      "revId": "4d1df7b0e75260c96164fd5a21347f5ce18c7a8b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "161a2127_dc639e31",
+        "filename": "validations_libs/cli/show.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 73,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-06-17T08:58:42Z",
+      "side": 0,
+      "message": "L71-73 to be removed.",
+      "revId": "4d1df7b0e75260c96164fd5a21347f5ce18c7a8b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "a070a0e0_e17cace6",
+        "filename": "validations_libs/cli/show.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 76,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-06-17T08:58:42Z",
+      "side": 0,
+      "message": "You can pass directly the constants.VALIDATION_GROUPS_INFO here instead of the groups_file variable coming the argument.",
+      "revId": "4d1df7b0e75260c96164fd5a21347f5ce18c7a8b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}

8217d7b3603b753b1654e06b8b012c372fd538ca

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "b14b3908_22295481",
+        "filename": "setup.cfg",
+        "patchSetId": 3
+      },
+      "lineNbr": 45,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-06-17T08:58:42Z",
+      "side": 1,
+      "message": "Don\u0027t change the subcommand name, it should remain the same as before the regression.",
+      "revId": "8217d7b3603b753b1654e06b8b012c372fd538ca",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}