Update patch set 4

Patch Set 4: Code-Review-1

(2 comments)

Patch-set: 4
Reviewer: Gerrit User 16515 <16515@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

22d3eb671cf1eeab9c295ee9186e16b4956cb8c4

@@ -0,0 +1,50 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "d24a8241_d448f5c6",
+        "filename": "validations_libs/cli/common.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 46,
+      "author": {
+        "id": 16515
+      },
+      "writtenOn": "2021-09-16T07:17:09Z",
+      "side": 1,
+      "message": "In some classic cases this is nice (like validation dir for example or default inventory), but generally it does not look very nice with all the None default value that we have by default in the CLI.\n\nAlso, those default are wrong if we have a config file which has set different values.\n\nExample of None and empty list default:\n\n  --extra-env-vars key1\u003d\u003cval1\u003e [--extra-env-vars key2\u003d\u003cval2\u003e]\n                        Add extra environment variables you may need to\n                        provide to your Ansible execution as KEY\u003dVALUE pairs.\n                        Note that if you pass the same KEY multiple times, the\n                        last given VALUE for that same KEY will override the\n                        other(s).\n                        (default: None)\n  --extra-vars key1\u003d\u003cval1\u003e [--extra-vars key2\u003d\u003cval2\u003e]\n                        Add Ansible extra variables to the validation(s)\n                        execution as KEY\u003dVALUE pair(s). Note that if you pass\n                        the same KEY multiple times, the last given VALUE for\n                        that same KEY will override the other(s).\n                        (default: None)\n  --extra-vars-file /tmp/my_vars_file.[json|yaml]\n                        Absolute or relative Path to a JSON/YAML file\n                        containing extra variable(s) to pass to one or\n                        multiple validation(s) execution.\n                        (default: None)\n  --validation \u003cvalidation_id\u003e[,\u003cvalidation_id\u003e,...]\n                        Run specific validations, if more than one validation\n                        is required separate the names with commas.\n                        (default: [])\n  --group \u003cgroup_id\u003e[,\u003cgroup_id\u003e,...], -g \u003cgroup_id\u003e[,\u003cgroup_id\u003e,...]\n                        Run specific group validations, if more than one group\n                        is required separate the group names with commas.\n                        (default: [])\n  --category \u003ccategory_id\u003e[,\u003ccategory_id\u003e,...]\n                        Run specific validations by category, if more than one\n                        category is required separate the category names with\n                        commas.\n                        (default: [])\n  --product \u003cproduct_id\u003e[,\u003cproduct_id\u003e,...]\n                        Run specific validations by product, if more than one\n                        product is required separate the product names with\n                        commas.\n                        (default: [])",
+      "range": {
+        "startLine": 43,
+        "startChar": 0,
+        "endLine": 46,
+        "endChar": 7
+      },
+      "revId": "22d3eb671cf1eeab9c295ee9186e16b4956cb8c4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "d56c6e89_f3d2d503",
+        "filename": "validations_libs/cli/constants.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 29,
+      "author": {
+        "id": 16515
+      },
+      "writtenOn": "2021-09-16T07:17:09Z",
+      "side": 1,
+      "message": "why dont just put those variables into the constants.py ?\nI\u0027m not very keen on adding a new file for constants, which can be confusing, I would prefer to see a section for CLI in the original constants.py file.",
+      "range": {
+        "startLine": 18,
+        "startChar": 0,
+        "endLine": 29,
+        "endChar": 61
+      },
+      "revId": "22d3eb671cf1eeab9c295ee9186e16b4956cb8c4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}