Update patch set 5

Patch Set 5: Code-Review+1

(1 comment)

Some thoughts about the example file structure.

Otherwise it looks good to me.

Here is the result of a simple run with the content of the example file included in this patch:

  [validations@6e68f352b08b ~]$ validation run --validation check-ram,check-cpu --inventory /etc/ansible/hosts --skiplist ~/skiplist.yaml
  Validation config file found: /usr/local/etc/validation.cfg
  Selected log directory '/home/validations/validations' does not exist. Attempting to create it.
  Validation check-cpu has been skipped on hosts: undercloud
  Skipping Validations: /usr/share/ansible/validation-playbooks/check-ram.yaml
  +--------------------------------------+-------------+--------+------------+----------------+-------------------+-------------+
| UUID                                 | Validations | Status | Host_Group | Status_by_Host | Unreachable_Hosts | Duration    |
+--------------------------------------+-------------+--------+------------+----------------+-------------------+-------------+
| c86f6cfd-9ea5-4dd9-ab60-ec264155cbb6 | check-cpu   | FAILED | localhost  | localhost      |                   | 0:00:00.856 |
+--------------------------------------+-------------+--------+------------+----------------+-------------------+-------------+
  One or more validations have failed.

Patch-set: 5
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1

c799d334200e752258fec8f04ac01a31eeeb5555

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "0460bc68_e02b4564",
+        "filename": "skiplist-example.yaml",
+        "patchSetId": 5
+      },
+      "lineNbr": 9,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-09-29T08:39:05Z",
+      "side": 1,
+      "message": "This example file should be commented and documented I think if we ship it or not via the rpm.\n\nMaybe, we need rules about the keys here? \n- if the hosts key is not present for a validation, it will mean \"hosts: all\"\n\nWe don\u0027t use them in the code so far but:\n- is reason AND/OR lp are mandatory?\n- what about BZ?\n\nWell, the file should be structured and documented in this file (in this patch) and in the official doc (in a following patch) such as the metadata for the validation playbooks",
+      "revId": "c799d334200e752258fec8f04ac01a31eeeb5555",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}