Update patch set 1

Patch Set 1:

(1 comment)

Granted, it would take a considerable degree of carelessness for anyone to write code modifying the args directly. Nevertheless, it's better to err on side of caution.

Patch-set: 1
CC: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 32926 2021-07-12 11:39:23 +00:00 committed by Gerrit Code Review
parent 4fb9a67049
commit 69a73f088a
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "171a3d59_5e7d5767",
"filename": "validations_libs/utils.py",
"patchSetId": 1
},
"lineNbr": 131,
"author": {
"id": 32926
},
"writtenOn": "2021-07-12T11:39:23Z",
"side": 1,
"message": "I have to advise against this. Using mutables as default values of args is considered undesirable, as the definition is evaluated once and mutable might be changed afterwards, affecting subsequent calls.\n\nhttps://docs.python.org/3.7/reference/compound_stmts.html#function-definitions",
"revId": "e9eae212b7e147ae10351c6da9559fdf4c6089b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}