From 77f3b37a9110120c5a3286f1dbd1b944b8f57c90 Mon Sep 17 00:00:00 2001 From: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 5 Aug 2021 08:55:38 +0000 Subject: [PATCH] Update patch set 7 Patch Set 7: (4 comments) > Patch Set 7: Code-Review-1 > > (4 comments) > > About the data collection part, I think it's worth adding examples of what they have to do or what they will have to see as results. Without example(s), procedures or commands, it could be confusing. This is an advanced topic, we have to assume that the users know how to run validations and that they have read at least the downstream docs. The very fact that they reached this page, means that they have run `command`, it failed, and they have determined that the error isn't on their side. The more information they give us to help solve the issue, the better. If we railroad them to much they might omit things that could be useful. Patch-set: 7 --- 0999476e6d3caf0290a2ebf0e100502ed6cc1d9f | 72 ++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/0999476e6d3caf0290a2ebf0e100502ed6cc1d9f b/0999476e6d3caf0290a2ebf0e100502ed6cc1d9f index 8ea1b565..34880bf3 100644 --- a/0999476e6d3caf0290a2ebf0e100502ed6cc1d9f +++ b/0999476e6d3caf0290a2ebf0e100502ed6cc1d9f @@ -17,6 +17,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": true }, + { + "key": { + "uuid": "429dd66a_43c900a4", + "filename": "doc/source/debugging.rst", + "patchSetId": 7 + }, + "lineNbr": 23, + "author": { + "id": 32926 + }, + "writtenOn": "2021-08-05T08:55:38Z", + "side": 1, + "message": "Done", + "parentUuid": "464d7e05_276365c0", + "revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "27e0677b_99ecfaff", @@ -34,6 +52,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": true }, + { + "key": { + "uuid": "50fea98f_6b3d5402", + "filename": "doc/source/debugging.rst", + "patchSetId": 7 + }, + "lineNbr": 41, + "author": { + "id": 32926 + }, + "writtenOn": "2021-08-05T08:55:38Z", + "side": 1, + "message": "Done", + "parentUuid": "27e0677b_99ecfaff", + "revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "7024551a_ea64585a", @@ -51,6 +87,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": true }, + { + "key": { + "uuid": "ec607fb9_73a8ce9a", + "filename": "doc/source/debugging.rst", + "patchSetId": 7 + }, + "lineNbr": 43, + "author": { + "id": 32926 + }, + "writtenOn": "2021-08-05T08:55:38Z", + "side": 1, + "message": "The cliff is fine with them both at the primary command and subcommand level. If you append them to the full command you get the same output as you would if you inserted them between main command and sub command.", + "parentUuid": "7024551a_ea64585a", + "revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + }, { "key": { "uuid": "4f02c3b4_26811abd", @@ -67,6 +121,24 @@ "revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": true + }, + { + "key": { + "uuid": "47e588b7_64491a6b", + "filename": "doc/source/debugging.rst", + "patchSetId": 7 + }, + "lineNbr": 46, + "author": { + "id": 32926 + }, + "writtenOn": "2021-08-05T08:55:38Z", + "side": 1, + "message": "All of them, I don\u0027t want to complicate things for the people debugging or for us. The point of this recommendation is to determine, right at the start, if the issue isn\u0027t triggered by some of the args. \n\nYes, the definition of \"bare minimum\" does depend what they are trying to accomplish. And yes, it is a subjective matter. But that is a good thing in this case as we want them to, indirectly, tell us what do they consider \u0027essential\u0027 for their use case.", + "parentUuid": "4f02c3b4_26811abd", + "revId": "0999476e6d3caf0290a2ebf0e100502ed6cc1d9f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true } ] } \ No newline at end of file