openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
This commit is contained in:
Gerrit User 16515 2021-06-04 12:18:59 +00:00 committed by Gerrit Code Review
parent b80a1ac57a
commit 850f925211
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
29b147e431e101f4de82e01bc2634a08b290bde2
View File

@ -52,6 +52,24 @@
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "dab7795e_eef40d57",
"filename": "validations_libs/cli/base.py",
"patchSetId": 5
},
"lineNbr": 23,
"author": {
"id": 16515
},
"writtenOn": "2021-06-04T12:18:59Z",
"side": 1,
"message": "Yep, I\u0027ve understood, but if this piece of code needs to be moved into run.py, it will be duplicated as well in history.py.\nSame for the lister, it will have to be duplicated in several places.\nIt serve actually a common role for all, eventually futur other cli implementations.",
"parentUuid": "bf32b441_cee3ca95",
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}