openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
This commit is contained in:
Gerrit User 32926 2021-09-14 10:50:55 +00:00 committed by Gerrit Code Review
parent 9dcd350f54
commit 887ad5e67a
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
344893a4905e83c3a54ac61c77b7ed90e7996719
View File

@ -193,6 +193,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "de185d16_d1c09b39",
"filename": "validations_libs/utils.py",
"patchSetId": 5
},
"lineNbr": 625,
"author": {
"id": 32926
},
"writtenOn": "2021-09-14T10:50:55Z",
"side": 1,
"message": "Reasonable change, it would simplify the code a bit as well.",
"parentUuid": "fc268503_2b4445e1",
"revId": "344893a4905e83c3a54ac61c77b7ed90e7996719",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b1d54fbb_4f800645",
@ -209,6 +227,24 @@
"revId": "344893a4905e83c3a54ac61c77b7ed90e7996719",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "4c7b9fde_b51435b1",
"filename": "validations_libs/utils.py",
"patchSetId": 5
},
"lineNbr": 647,
"author": {
"id": 32926
},
"writtenOn": "2021-09-14T10:50:55Z",
"side": 1,
"message": "Eh, need is a relative term, but in this case I tend to agree. The schema is getting a bit too strict already.",
"parentUuid": "b1d54fbb_4f800645",
"revId": "344893a4905e83c3a54ac61c77b7ed90e7996719",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}