From 8ce7643b97a1ef1164dbc9bfb9ccf18c8020b41c Mon Sep 17 00:00:00 2001
From: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Wed, 5 May 2021 11:31:03 +0000
Subject: [PATCH] Update patch set 9

Patch Set 9: Code-Review-1

(2 comments)

If the output is limited by default to the last 15 executions, it would be great to inform the user here!

If he wants to get the info about a run which happened before those 15 ones, he could be confused by the default behavior.

Honestly, I would prefer to list everything by default and let the user limiting to what he wants!

My 2cts

Patch-set: 9
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
---
 4e20ceb3898c37d6f1832ee699cf9e9da35740b1 | 38 ++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 4e20ceb3898c37d6f1832ee699cf9e9da35740b1

diff --git a/4e20ceb3898c37d6f1832ee699cf9e9da35740b1 b/4e20ceb3898c37d6f1832ee699cf9e9da35740b1
new file mode 100644
index 00000000..40dd32f7
--- /dev/null
+++ b/4e20ceb3898c37d6f1832ee699cf9e9da35740b1
@@ -0,0 +1,38 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3a6d3959_436192dd",
+        "filename": "validations_libs/cli/history.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 47,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-05-05T11:31:03Z",
+      "side": 1,
+      "message": "Then we should mention the default value in the helper.",
+      "revId": "4e20ceb3898c37d6f1832ee699cf9e9da35740b1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "095c92cb_03bf6956",
+        "filename": "validations_libs/cli/history.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 62,
+      "author": {
+        "id": 11491
+      },
+      "writtenOn": "2021-05-05T11:31:03Z",
+      "side": 1,
+      "message": "I would inform the user here about the default intention to list only the last 15 executions.\n\n          self.app.LOG.info(\"Listing the last {:d} executions:\".format(\n            parsed_args.history_limit))",
+      "revId": "4e20ceb3898c37d6f1832ee699cf9e9da35740b1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}
\ No newline at end of file