openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(2 comments)

Code looks good and works great!

Only have some questions here.

Patch-set: 4
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 11491 2021-07-30 19:37:20 +00:00 committed by Gerrit Code Review
parent 413ba93429
commit 8d5a36fa51
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
d41a40c858712d2fc5d8a5f743f9b02cb32a27b8 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "97aea581_c685eefc",
"filename": "validations_libs/validation_actions.py",
"patchSetId": 4
},
"lineNbr": 20,
"author": {
"id": 11491
},
"writtenOn": "2021-07-30T19:37:20Z",
"side": 1,
"message": "Why?",
"revId": "d41a40c858712d2fc5d8a5f743f9b02cb32a27b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "111bb65d_df6cff1d",
"filename": "validations_libs/validation_actions.py",
"patchSetId": 4
},
"lineNbr": 538,
"author": {
"id": 11491
},
"writtenOn": "2021-07-30T19:37:20Z",
"side": 1,
"message": "Why displaying only the groups with at least one validation belonging to?\n\nWe should display all the groups.",
"revId": "d41a40c858712d2fc5d8a5f743f9b02cb32a27b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}