From 9616a98ca175c74aea3532a411c3d1c15a1aee3e Mon Sep 17 00:00:00 2001
From: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Mon, 27 Sep 2021 06:53:49 +0000
Subject: [PATCH] Update patch set 2

Patch Set 2: Code-Review-1

(3 comments)

Code is solid overall, but I think there should be more focus on possible edge cases and error handling. Otherwise we might end up with some nasty bugs down the line.

Patch-set: 2
Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
---
 bef53bc2f63d85b7b8a85e4327db38065b78e9a6 | 51 ++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/bef53bc2f63d85b7b8a85e4327db38065b78e9a6 b/bef53bc2f63d85b7b8a85e4327db38065b78e9a6
index 29845e18..736e2b69 100644
--- a/bef53bc2f63d85b7b8a85e4327db38065b78e9a6
+++ b/bef53bc2f63d85b7b8a85e4327db38065b78e9a6
@@ -17,6 +17,57 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "9f1573d3_57b4c374",
+        "filename": "validations_libs/cli/common.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 105,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-09-27T06:53:49Z",
+      "side": 1,
+      "message": "This function really needs another test case, for the YAMLError.\nIf things go wrong here we might end up with incorrect or no validations executing.",
+      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "59d764f0_3db4f545",
+        "filename": "validations_libs/cli/common.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 106,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-09-27T06:53:49Z",
+      "side": 1,
+      "message": "Since you are already writing docsrings, specification of the argument and return value would be nice :).",
+      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "a04d73ef_e8a12599",
+        "filename": "validations_libs/cli/common.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 111,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-09-27T06:53:49Z",
+      "side": 1,
+      "message": "I think this should be expanded to cover common IO errors.",
+      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "9e8c8f47_b193d796",