Update patch set 1

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"jpodivin replied on the change"}
This commit is contained in:
Gerrit User 32926 2022-05-16 06:43:39 +00:00 committed by Gerrit Code Review
parent e5d474cba7
commit 9949af77d7
1 changed files with 55 additions and 0 deletions

View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d46fd9ae_177c6c21",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 32926
},
"writtenOn": "2022-05-16T06:43:39Z",
"side": 1,
"message": "This is great. I\u0027ll have to give it a proper read however, as I know of some cases when side effects of six were used to control the flow.\n\nIn any case, it might be better to leave the setup.cfg out of the review, as we have one review open for it already[1].\n\n[1]https://review.opendev.org/c/openstack/validations-libs/+/840438",
"revId": "67940818b4ae55593f6c8b1f4d48b6796eb80bbc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2c847961_fda16de2",
"filename": "setup.cfg",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 32926
},
"writtenOn": "2022-05-16T06:43:39Z",
"side": 1,
"message": "I believe this key actually belongs in the `options` section.[0]\n\n[0]https://setuptools.pypa.io/en/latest/userguide/dependency_management.html?highlight\u003dpython_requires#python-requirement",
"revId": "67940818b4ae55593f6c8b1f4d48b6796eb80bbc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b9930871_50570d51",
"filename": "setup.cfg",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 32926
},
"writtenOn": "2022-05-16T06:43:39Z",
"side": 1,
"message": "Good point about the classifier. I\u0027ve completely forgotten about that.",
"revId": "67940818b4ae55593f6c8b1f4d48b6796eb80bbc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}