Browse Source

Update patch set 26

Patch Set 26:

(3 comments)

Patch-set: 26
Reviewer: Gerrit User 16515 <16515@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
changes/74/789174/meta
Gerrit User 16515 1 month ago
committed by Gerrit Code Review
parent
commit
a418abcd33
1 changed files with 73 additions and 0 deletions
  1. +73
    -0
      27844cdcea0069a4fee7dcfa828dd011b63d52d1

+ 73
- 0
27844cdcea0069a4fee7dcfa828dd011b63d52d1 View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "11d36b51_67ad58d8",
"filename": "validations_libs/utils.py",
"patchSetId": 26
},
"lineNbr": 72,
"author": {
"id": 16515
},
"writtenOn": "2021-05-05T13:44:28Z",
"side": 1,
"message": "I think the missing part here is the check to see if the log_path provided by the caller is writable.",
"range": {
"startLine": 52,
"startChar": 0,
"endLine": 72,
"endChar": 19
},
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "db5f73f3_1f3ea90c",
"filename": "validations_libs/utils.py",
"patchSetId": 26
},
"lineNbr": 104,
"author": {
"id": 16515
},
"writtenOn": "2021-05-05T13:44:28Z",
"side": 1,
"message": "no log/validations but /validations/ right ?\nand no more /tmp ?",
"range": {
"startLine": 102,
"startChar": 1,
"endLine": 104,
"endChar": 0
},
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "7c8601a2_2d780391",
"filename": "validations_libs/utils.py",
"patchSetId": 26
},
"lineNbr": 139,
"author": {
"id": 16515
},
"writtenOn": "2021-05-05T13:44:28Z",
"side": 1,
"message": "and here, at this stage, we assume that the place where the \"artifacts\" directory will be created is sane and writable, so no need to check or default anything.\n\nAnd mainly because, if this dir can not be created, the callback wont be able to write in the log path.\n\nSo every logic to check if log path is correct should happen before.\n\nI suggest to revert to the original function for this part.",
"range": {
"startLine": 117,
"startChar": 0,
"endLine": 139,
"endChar": 41
},
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}

Loading…
Cancel
Save