Update patch set 7

Patch Set 7:

(2 comments)

Patch-set: 7
Reviewer: Gerrit User 28223 <28223@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 28223 2021-05-04 10:14:24 +00:00 committed by Gerrit Code Review
parent 54c3dc87de
commit ad304aa0a7
1 changed files with 44 additions and 0 deletions

View File

@ -0,0 +1,44 @@
{
"comments": [
{
"key": {
"uuid": "6539d51c_a87ff3d0",
"filename": "validations_libs/cli/history.py",
"patchSetId": 7
},
"lineNbr": 40,
"author": {
"id": 28223
},
"writtenOn": "2021-05-04T10:14:24Z",
"side": 1,
"message": "Wondering if we shouldn\u0027t enforce a default in order to avoid endless listing? what about 15?",
"revId": "e90cfdaef669dde6092d848f6931b756f226032d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "a42037fb_2f65ba9d",
"filename": "validations_libs/cli/history.py",
"patchSetId": 7
},
"lineNbr": 53,
"author": {
"id": 28223
},
"writtenOn": "2021-05-04T10:14:24Z",
"side": 1,
"message": "you might do the same check as shown in the doc string (\u003e 0). For the sake of consistency.",
"range": {
"startLine": 53,
"startChar": 67,
"endLine": 53,
"endChar": 70
},
"revId": "e90cfdaef669dde6092d848f6931b756f226032d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}