Update patch set 3

Browse Source

Patch Set 3: Code-Review-1

I am not very convinced 😕 about mocking the output and especially the PrettyTable(s) here.

The ones displayed through the stdout are important when running the unit tests locally IMO. And we have the colors as well... and it is still easy to parse.

About the storage usage, CI logs are purged regularly and automatically. And we are talking about hundred lines of logs, not thousands here.

Still not convinced which will be the profit(s) of this change.

Patch-set: 3
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

...

This commit is contained in:

Gerrit User 11491 2021-07-21 09:11:27 +00:00 committed by Gerrit Code Review

parent 70ac14e0cd

commit b2d52674b9

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available