Update patch set 4
Patch Set 4: Code-Review-1 (2 comments) Are we installing the 'skiplist-example.yaml' file with the package? If so it should be in the setup.cfg and the ".spec" file of the package. Otherwise we might want to put it in the docs. Patch-set: 4 Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
debed39d68
commit
b54c9a5b5c
|
@ -0,0 +1,38 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "21f288d9_1396ca23",
|
||||
"filename": "skiplist-example.yaml",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 1,
|
||||
"author": {
|
||||
"id": 32926
|
||||
},
|
||||
"writtenOn": "2021-09-29T06:59:10Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027m starting to think that we might need a dedicated dir for the various files we are including with the VF packages.",
|
||||
"revId": "0ffb20ab002158f9f38f3fe6ca5a268da50ff0d3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "a9e2fe9a_594a1a58",
|
||||
"filename": "validations_libs/validation_actions.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 191,
|
||||
"author": {
|
||||
"id": 32926
|
||||
},
|
||||
"writtenOn": "2021-09-29T06:59:10Z",
|
||||
"side": 1,
|
||||
"message": "There might be a space for simplification here. Getting \u0027all\u0027 by default would turn two conditions on the line 192 into one. And we could avoid the call to `lower()` method of the string.",
|
||||
"revId": "0ffb20ab002158f9f38f3fe6ca5a268da50ff0d3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue