Update patch set 21

Patch Set 21:

> Patch Set 21: Code-Review-1
> 
> (1 comment)
> 
> Just tried to use a relative path for the validation-log-dir and I've got this issue:
> 
>    [stack@undercloud ~]$ validation -v --debug run --validation 512e --validation-log-dir mylogs_dir 
>    Initialize Validation App.
>    prepare_to_run_command Run
>    Selected log directory 'mylogs_dir' does not exist. Attempting to create it.
>    Running the validations with Ansible
>    Ansible playbook /usr/share/ansible/validation-playbooks/512e.yaml found
>    Running Ansible playbook: /usr/share/ansible/validation-playbooks/512e.yaml, Working directory:    mylogs_dir/artifacts/157464b5-016a-42f1-97a2-5560cd1e9e21_512e.yaml_2021-06-10T09:51:42.115528Z,    Playbook directory: /usr/share/ansible/validation-playbooks  
>    No validation has been run, please check log in the Ansible working directory.
>    Traceback (most recent call last):
>      File "/usr/lib/python3.6/site-packages/cliff/app.py", line 401, in run_subcommand
>        result = cmd.run(parsed_args)
>      File "/usr/lib/python3.6/site-packages/cliff/command.py", line 185, in run
>        return_code = self.take_action(parsed_args) or 0
>      File "/usr/local/lib/python3.6/site-packages/validations_libs/cli/run.py", line 198, in take_action
>        raise RuntimeError(msg)
>    RuntimeError: No validation has been run, please check log in the Ansible working directory.
>    clean_up Run
>    got an error: No validation has been run, please check log in the Ansible working directory.
> 
> 
> The mylogs_dir has been created where I run the validation command but it fails when trying to write the logs... ;)
> 
> And some minor improvements/adjustments should be addressed in the help rendering output!

Done.

Patch-set: 21
Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 32926 2021-06-10 10:32:28 +00:00 committed by Gerrit Code Review
parent c7ab3e2724
commit be0f23f542

Diff Content Not Available