Update patch set 3
Patch Set 3: (9 comments) Please note that English is not my first language so some of these suggestions might not be the best. Except for these little nits, I think this doc is good to have. I think it could benefit from examples with full commands just so it's clear to the user. Patch-set: 3 Reviewer: Gerrit User 27419 <27419@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 27419
Gerrit Code Review
parent
d14c20f800
commit
c0dd80b984
|
|
@ -17,6 +17,75 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "c196b7ee_68e09e44",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "includes?",
|
||||
"range": {
|
||||
"startLine": 7,
|
||||
"startChar": 22,
|
||||
"endLine": 7,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "edeba112_363c8805",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "a?",
|
||||
"range": {
|
||||
"startLine": 8,
|
||||
"startChar": 6,
|
||||
"endLine": 8,
|
||||
"endChar": 10
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "f2fa8c24_88f4c77b",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "\"the following simple guidelines can help\"\n\nbtw, \"bellow\" is a roar ;)",
|
||||
"range": {
|
||||
"startLine": 10,
|
||||
"startChar": 19,
|
||||
"endLine": 11,
|
||||
"endChar": 47
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "6d2b26c0_a5e2e4bb",
|
||||
|
|
@ -34,6 +103,52 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "b55076f1_c34d252a",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "Validate*",
|
||||
"range": {
|
||||
"startLine": 32,
|
||||
"startChar": 2,
|
||||
"endLine": 32,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "96408bf8_4fa94513",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "Validate*",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 2,
|
||||
"endLine": 33,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fe02c1e0_1ec3e971",
|
||||
|
|
@ -51,6 +166,46 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "164b9363_3a9d81f0",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 39,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "I think I\u0027d add a step to manually run the ansible-playbook command?\n\nAlso, some roles have a _debug variable that can be leveraged.",
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "73b05666_1fd8f56c",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 44,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "Made me smile but I wouldn\u0027t put this here 😊",
|
||||
"range": {
|
||||
"startLine": 44,
|
||||
"startChar": 52,
|
||||
"endLine": 44,
|
||||
"endChar": 78
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ab6cb80b_a2c409c5",
|
||||
|
|
@ -68,6 +223,47 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "a372ba57_09788d7b",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "+1 on this",
|
||||
"parentUuid": "ab6cb80b_a2c409c5",
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "2da820f9_0ca9d1ce",
|
||||
"filename": "doc/source/debugging.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 54,
|
||||
"author": {
|
||||
"id": 27419
|
||||
},
|
||||
"writtenOn": "2021-06-23T13:23:41Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027d remove this line as it\u0027s expected that people will validate and re-read, otherwise we should include this line everywhere in our doc 😊",
|
||||
"range": {
|
||||
"startLine": 53,
|
||||
"startChar": 0,
|
||||
"endLine": 54,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "37324ffe_f558385e",
|
||||
|
|
|
|||
Loading…
Reference in New Issue