Browse Source

Update patch set 5

Patch Set 5: Code-Review+1

(2 comments)

inline question on the commit message otherwise lgtm

Patch-set: 5
Reviewer: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
changes/49/780849/meta
Gerrit User 8449 3 months ago
committed by Gerrit Code Review
parent
commit
c838f25d57
  1. 27
      18862912b36ff85caf371975564f095447482ede
  2. 27
      af6e2b29a17c0c59d74508ace4c771bfae5268b6

27
18862912b36ff85caf371975564f095447482ede

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "727184d6_def2a90a",
"filename": "tox.ini",
"patchSetId": 5
},
"lineNbr": 81,
"author": {
"id": 8449
},
"writtenOn": "2021-04-26T08:36:02Z",
"side": 0,
"message": "ack i see it there https://opendev.org/openstack/validations-libs/src/commit/132d2801dbf6c631d3319b9977c309595a98dc03/.coveragerc#L3 you aren\u0027t lying ;)",
"range": {
"startLine": 81,
"startChar": 24,
"endLine": 81,
"endChar": 47
},
"revId": "18862912b36ff85caf371975564f095447482ede",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}

27
af6e2b29a17c0c59d74508ace4c771bfae5268b6

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "a34dfb46_56ab3588",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 18,
"author": {
"id": 8449
},
"writtenOn": "2021-04-26T08:36:02Z",
"side": 1,
"message": "what is that please? gerrit review? lp bug? etc",
"range": {
"startLine": 18,
"startChar": 12,
"endLine": 18,
"endChar": 18
},
"revId": "af6e2b29a17c0c59d74508ace4c771bfae5268b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}
Loading…
Cancel
Save