openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review+2

(2 comments)

Nitpicking about doc but this patch is working very well according to my tests.

Patch-set: 7
Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 11491 2021-10-06 12:35:13 +00:00 committed by Gerrit Code Review
parent 82beeff85c
commit d65b624e45
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
2ad92c3a6ade415ead0108501e94bf668356a12a Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "6e78fb78_54d97ee6",
"filename": "README.rst",
"patchSetId": 7
},
"lineNbr": 68,
"author": {
"id": 11491
},
"writtenOn": "2021-10-06T12:35:13Z",
"side": 1,
"message": "to be compliant with the above part, I would add --inventory /etc/ansible/hosts after --skiplist argument.",
"revId": "2ad92c3a6ade415ead0108501e94bf668356a12a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "9492c2a4_2a9f58ef",
"filename": "README.rst",
"patchSetId": 7
},
"lineNbr": 83,
"author": {
"id": 11491
},
"writtenOn": "2021-10-06T12:35:13Z",
"side": 1,
"message": "I would even add if no \u0027hosts: ...\u0027 line for a validation is present, the same behavior is applied here.",
"revId": "2ad92c3a6ade415ead0108501e94bf668356a12a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}