Update patch set 4

Patch Set 4: Code-Review-1

(7 comments)

Patch-set: 4
Reviewer: Gerrit User 32926 <32926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

73b2ef78b74b768b2cae845c38f5de17d3050cb1

@@ -0,0 +1,123 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "dde904ce_798f4fef",
+        "filename": "validations_libs/utils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 174,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "This should be changed to an elif. As the condition will always evaluate to \u0027True\u0027 if we first trigger conditional on 171. Same goes for the groups argument.",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "5ca0b1f9_584ceb59",
+        "filename": "validations_libs/utils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 198,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "This conditional should be refactored. If we have an empty list, for example because we haven\u0027t passed any \u0027groups\u0027 to the function, the result of the intersection will be an empty set.\nWhich will evaluate to False.\n\nSame goes for categories.",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "1d51514f_3505e7e8",
+        "filename": "validations_libs/utils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 255,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "Same as in \u0027parse_all_validations_on_disk\u0027",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "03774bd7_827ef1f7",
+        "filename": "validations_libs/utils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 271,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "ditto",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "baca4b78_12e5705d",
+        "filename": "validations_libs/utils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 439,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "ditto",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "259cccb5_a2e6ae8c",
+        "filename": "validations_libs/utils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 441,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "ditto",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "99984639_7f2c2b2b",
+        "filename": "validations_libs/validation_actions.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 525,
+      "author": {
+        "id": 32926
+      },
+      "writtenOn": "2021-07-14T08:46:18Z",
+      "side": 1,
+      "message": "As in the \u0027utils\u0027 module. elif would work better here.",
+      "revId": "73b2ef78b74b768b2cae845c38f5de17d3050cb1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}