Update patch set 5
Patch Set 5: Code-Review+1 (2 comments) Thanks for implementing it! This is really useful for our validation testing. Patch-set: 5 Reviewer: Gerrit User 26343 <26343@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1
This commit is contained in:
parent
ae795ec63f
commit
de88aa6b31
|
@ -17,6 +17,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "e610b01c_f84c3859",
|
||||
"filename": "skiplist-example.yaml",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 26343
|
||||
},
|
||||
"writtenOn": "2021-09-30T10:31:36Z",
|
||||
"side": 1,
|
||||
"message": "Good point from Gael, I would say the mandatory field needs to be the hosts (or set a default, if not present then use hosts:all) the other fields are nice to have but I wouldn\u0027t block the validation run if not present (imho).",
|
||||
"parentUuid": "0460bc68_e02b4564",
|
||||
"revId": "c799d334200e752258fec8f04ac01a31eeeb5555",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "db3bac82_e7d8a56f",
|
||||
|
@ -50,6 +68,23 @@
|
|||
"revId": "c799d334200e752258fec8f04ac01a31eeeb5555",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "c71de9da_c223d8e5",
|
||||
"filename": "validations_libs/validation_actions.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 192,
|
||||
"author": {
|
||||
"id": 26343
|
||||
},
|
||||
"writtenOn": "2021-09-30T10:31:36Z",
|
||||
"side": 1,
|
||||
"message": "Ok, I can see that the default if not being passed is skip it in all hosts. Disregard my previous comment then.",
|
||||
"revId": "c799d334200e752258fec8f04ac01a31eeeb5555",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue