Update patch set 3

Browse Source

Patch Set 3:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > Is there a reason to not implement the 'NOT_RUN' (which is basically a "skipped") status? It would be different than "passed" and it is worth keeping it separate (unless it can't happen, but I'm not sure).
> 
> Some tasks could be skipped during the run of the validation but it doesn't mean that the validation has not been run at all. The status of the validation should be PASSED or FAILED but I agree that it could be interesting to differentiate validation which should run only if the service/component is enabled on the deployment. For example, if tls-everywhere is not enabled the validations should pass successfully but the user should be aware of that in the result. This is actually not the case today!

The case where a service is not enabled is exactly where the validation shouldn't pass but say "nothing could have been tested", which is in fact skipped. This is the case with other testing frameworks.
Do you want to have this request tracked somewhere?

Patch-set: 3

...

This commit is contained in:

Gerrit User 10459 2021-05-31 08:46:51 +00:00 committed by Gerrit Code Review

parent 30f9e7d92e

commit deccfab251

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available