Update patch set 6
Patch Set 6: Code-Review-1 (1 comment) Besides the formatting issue, I really think it would be better to do this in the run_validations method of the ValidationActions class. During the run, when we arrive here [1], we have the absolute path of all the validations the user wants to execute and we had already applied some check to verify they exist! Moreover, we won't have a piece of the spinner before the result of the schema verification [2]! [1] - https://opendev.org/openstack/validations-libs/src/branch/master/validations_libs/validation_actions.py#L406 [2] - https://paste.opendev.org/show/809359/ Patch-set: 6 Reviewer: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
db7f53937e
commit
e858979d4a
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "8cae0e52_361d65a0",
|
||||
"filename": "validations_libs/ansible.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 76,
|
||||
"author": {
|
||||
"id": 11491
|
||||
},
|
||||
"writtenOn": "2021-09-16T08:46:10Z",
|
||||
"side": 1,
|
||||
"message": "something is done wrong here, got this:\n\nhttps://paste.opendev.org/show/809359/",
|
||||
"revId": "302e7841e302a9d5aad8eab8148f21f66a102388",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue