openstack
/
validations-libs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
CC: Gerrit User 11491 <11491@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 11491 2021-06-03 11:49:43 +00:00 committed by Gerrit Code Review
parent 5ae5fbebd0
commit f558ceceed
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
5da1e1676e89ee602cdfbb01ddc8c1ae30ac326a Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "e498ef41_bda05049",
"filename": "validations_libs/cli/history.py",
"patchSetId": 4
},
"lineNbr": 30,
"author": {
"id": 11491
},
"writtenOn": "2021-06-03T11:49:43Z",
"side": 1,
"message": "shouldn\u0027t be log_dir\u003dconstants.VALIDATION_VALIDATIONS_LOG_BASEDIR ?",
"revId": "5da1e1676e89ee602cdfbb01ddc8c1ae30ac326a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "7617bde3_cb3c16fa",
"filename": "validations_libs/cli/run.py",
"patchSetId": 4
},
"lineNbr": 31,
"author": {
"id": 11491
},
"writtenOn": "2021-06-03T11:49:43Z",
"side": 1,
"message": "ditto?",
"revId": "5da1e1676e89ee602cdfbb01ddc8c1ae30ac326a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}