validations-libs/f7316f0a28818e278e884c57842...

92 lines
3.0 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "1f832a1a_23ee9de1",
"filename": "validations_libs/tests/cli/fakes.py",
"patchSetId": 2
},
"lineNbr": 48,
"author": {
"id": 11491
},
"writtenOn": "2021-05-26T08:50:54Z",
"side": 1,
"message": "I would add multiple key\u003dvalue comma-separated as well.\n\nfoo1\u003dbar1,foo2\u003dbar2",
"revId": "f7316f0a28818e278e884c57842813339ae7ed27",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "06cb75a2_b00c570c",
"filename": "validations_libs/tests/cli/fakes.py",
"patchSetId": 2
},
"lineNbr": 48,
"author": {
"id": 32926
},
"writtenOn": "2021-05-26T09:20:50Z",
"side": 1,
"message": "I would too, but the CLI isn\u0027t designed to accept such input. \nIt might be an oversight, but the way things are now, if you supply a comma separated list to the CLI as extra vars, it will fail with the \u0027ArgumentTypeError\u0027.\nIf you want to pass multiple variables, you need specify them in their own `--extra-vas` arg. \n\nRedesigning it is possible but beyond scope of this patch.",
"parentUuid": "1f832a1a_23ee9de1",
"revId": "f7316f0a28818e278e884c57842813339ae7ed27",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "f2801300_89017eff",
"filename": "validations_libs/tests/cli/fakes.py",
"patchSetId": 2
},
"lineNbr": 48,
"author": {
"id": 11491
},
"writtenOn": "2021-05-26T09:26:43Z",
"side": 1,
"message": "I am quite aware of the design and I know that I have to pass multiple --extra-vars argument!\nI didn\u0027t ask for a redesign here, I would just like to see that case tested.\nThat\u0027s it! ;-)",
"parentUuid": "06cb75a2_b00c570c",
"revId": "f7316f0a28818e278e884c57842813339ae7ed27",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "035f305c_2dcd2c1a",
"filename": "validations_libs/tests/cli/fakes.py",
"patchSetId": 2
},
"lineNbr": 48,
"author": {
"id": 32926
},
"writtenOn": "2021-05-26T09:37:49Z",
"side": 1,
"message": "Done",
"parentUuid": "f2801300_89017eff",
"revId": "f7316f0a28818e278e884c57842813339ae7ed27",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "723331c7_7f890855",
"filename": "validations_libs/tests/cli/test_parseractions.py",
"patchSetId": 2
},
"lineNbr": 39,
"author": {
"id": 11491
},
"writtenOn": "2021-05-26T08:50:54Z",
"side": 1,
"message": "Trailing whitespaces here.",
"revId": "f7316f0a28818e278e884c57842813339ae7ed27",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}