validations-libs/a24fb5dc2ecb086c5ed3642f1d6...

39 lines
3.3 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "302dd476_6a0d22b9",
"filename": "validations_libs/cli/run.py",
"patchSetId": 21
},
"lineNbr": 98,
"author": {
"id": 11491
},
"writtenOn": "2021-06-10T09:57:52Z",
"side": 1,
"message": "Could you please group the --validation-log-dir argument with --validation-dir/--ansible-base-dir? \n\nAnd remove the metavar to be compliant with the other ones?\n\nI\u0027ve got this otherwise:\n\n optional arguments:\n -h, --help show this help message and exit\n --limit LIMIT A string that identifies a single node or comma-\n separated list of nodes to be upgraded in parallel in\n this upgrade run invocation. For example: --limit\n \"compute-0,compute-1,compute-5\".\n --ssh-user SSH_USER SSH user name for the Ansible ssh connection.\n --validation-dir VALIDATION_DIR\n Path where the validation playbooks is located.\n --ansible-base-dir ANSIBLE_BASE_DIR\n Path where the ansible roles, library and plugins are\n located.\n --inventory INVENTORY, -i INVENTORY\n Path of the Ansible inventory.\n --output-log OUTPUT_LOG\n Path where the run result will be stored.\n --junitxml JUNITXML Path where the run result in JUnitXML format will be\n stored.\n --python-interpreter --python-interpreter \u003cPYTHON_INTERPRETER_PATH\u003e\n Python interpreter for Ansible execution.\n --extra-env-vars key1\u003d\u003cval1\u003e [--extra-vars key3\u003d\u003cval3\u003e]\n Add extra environment variables you may need to\n provide to your Ansible execution as KEY\u003dVALUE pairs.\n Note that if you pass the same KEY multiple times, the\n last given VALUE for that same KEY will override the\n other(s)\n --validation-log-dir \u003cLOG-DIR\u003e\n Path where the log files and artifacts will be\n located.\n --extra-vars key1\u003d\u003cval1\u003e [--extra-vars key3\u003d\u003cval3\u003e]\n Add Ansible extra variables to the validation(s)\n execution as KEY\u003dVALUE pair(s). Note that if you pass\n the same KEY multiple times, the last given VALUE for\n that same KEY will override the other(s)",
"revId": "a24fb5dc2ecb086c5ed3642f1d6ea24763e1cc1d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "fcd349f6_ef61479f",
"filename": "validations_libs/cli/run.py",
"patchSetId": 21
},
"lineNbr": 98,
"author": {
"id": 32926
},
"writtenOn": "2021-06-10T10:32:55Z",
"side": 1,
"message": "Done",
"parentUuid": "302dd476_6a0d22b9",
"revId": "a24fb5dc2ecb086c5ed3642f1d6ea24763e1cc1d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}