validations-libs/e0839fa8af301dd1d773edc6d46a94d78fdbffe1

{
  "comments": [
    {
      "key": {
        "uuid": "1f47cebd_1a9ea421",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 47,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-07-29T21:29:06Z",
      "side": 1,
      "message": "Could add what you did in [1] about the validation_path arg?\n\n[1] https://review.opendev.org/c/openstack/validations-libs/+/796482",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "d69f64a3_8cef892b",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 47,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-07-30T06:40:51Z",
      "side": 1,
      "message": "I have rebased this patch on top of the [1],",
      "parentUuid": "1f47cebd_1a9ea421",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "2e395d57_330b6432",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 190,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-07-29T21:29:06Z",
      "side": 1,
      "message": "Don\u0027t add a tab or spaces here for the example to be consistent with the others. please.",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "61e30edf_98e10fcf",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 190,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-07-30T06:40:51Z",
      "side": 1,
      "message": "The example wasn\u0027t in valid format though. Each statement has to start with \u0027\u003e\u003e\u003e\u0027 and continuing lines with ellipses, just like in python interactive interpreter.\n\nAnd if we do that we need to add indentation level, so the docs render properly.",
      "parentUuid": "2e395d57_330b6432",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "9256d294_6c5b0748",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 190,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-07-30T08:07:50Z",
      "side": 1,
      "message": "Yes I got it but I was talking about the indentation of the \u0027\u003e\u003e\u003e\u0027 and continuing lines with ellipses. There is no need to add a \u003cTAB\u003e or spaces here.\n\nAnd btw, the private methods are not auto documented in sphinx!",
      "parentUuid": "61e30edf_98e10fcf",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "e97e38cd_0b18ee60",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 190,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-07-30T10:11:34Z",
      "side": 1,
      "message": "The tabs are needed, or else it will be rather hard to read in editor, which, as you noted, is the only place this docstring will show up.",
      "parentUuid": "9256d294_6c5b0748",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "45d7342c_a7901d88",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 242,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-07-29T21:29:06Z",
      "side": 1,
      "message": "Here too, please.",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "7f659d47_21cccb88",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 1
      },
      "lineNbr": 242,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-07-30T06:40:51Z",
      "side": 1,
      "message": "ditto",
      "parentUuid": "45d7342c_a7901d88",
      "revId": "e0839fa8af301dd1d773edc6d46a94d78fdbffe1",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}