openstack
/
validations-libs
Code Issues Proposed changes
validations-libs/b2e7a44220a973f347694f29324...

572 lines
15 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "d46667c5_dc0e907b",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 27427
},
"writtenOn": "2021-06-23T13:02:30Z",
"side": 1,
"message": "typo - debugging",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "2faf11c4_60e655b6",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "d46667c5_dc0e907b",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "c196b7ee_68e09e44",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "includes?",
"range": {
"startLine": 7,
"startChar": 22,
"endLine": 7,
"endChar": 27
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "edeba112_363c8805",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 8,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "a?",
"range": {
"startLine": 8,
"startChar": 6,
"endLine": 8,
"endChar": 10
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "f31f9fb3_a476cf2b",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 8,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "In retrospect that whole sentence is has to be rewritten.",
"parentUuid": "edeba112_363c8805",
"range": {
"startLine": 8,
"startChar": 6,
"endLine": 8,
"endChar": 10
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "f2fa8c24_88f4c77b",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 11,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "\"the following simple guidelines can help\"\n\nbtw, \"bellow\" is a roar ;)",
"range": {
"startLine": 10,
"startChar": 19,
"endLine": 11,
"endChar": 47
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "e58d00c6_db94d25d",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 11,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Heh :)",
"parentUuid": "f2fa8c24_88f4c77b",
"range": {
"startLine": 10,
"startChar": 19,
"endLine": 11,
"endChar": 47
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "6d2b26c0_a5e2e4bb",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 23,
"author": {
"id": 27427
},
"writtenOn": "2021-06-23T13:02:30Z",
"side": 1,
"message": "typo - consider",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "4ca66ef4_7ea9655a",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 23,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "6d2b26c0_a5e2e4bb",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "b55076f1_c34d252a",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 32,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "Validate*",
"range": {
"startLine": 32,
"startChar": 2,
"endLine": 32,
"endChar": 8
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "ee8256cd_379d4a6a",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 32,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "I\u0027d like to avoid that verb. As it could be confused with running actual validation.\nI\u0027ll go with check.",
"parentUuid": "b55076f1_c34d252a",
"range": {
"startLine": 32,
"startChar": 2,
"endLine": 32,
"endChar": 8
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "96408bf8_4fa94513",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 33,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "Validate*",
"range": {
"startLine": 33,
"startChar": 2,
"endLine": 33,
"endChar": 8
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "19c6110f_421e77a0",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 33,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "ditto",
"parentUuid": "96408bf8_4fa94513",
"range": {
"startLine": 33,
"startChar": 2,
"endLine": 33,
"endChar": 8
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "fe02c1e0_1ec3e971",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 37,
"author": {
"id": 27427
},
"writtenOn": "2021-06-23T13:02:30Z",
"side": 1,
"message": "typo - its",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "a38aa501_828ab44e",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 37,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "fe02c1e0_1ec3e971",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "164b9363_3a9d81f0",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "I think I\u0027d add a step to manually run the ansible-playbook command?\n\nAlso, some roles have a _debug variable that can be leveraged.",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "a3ec29ac_7bddda60",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Most of the issues we encounter are related either to the CLI, or the way VF handles plays and the related I/O. \n\nI guess running the validation manually could give us some information, but I\u0027m not sure how much of it would be relevant.",
"parentUuid": "164b9363_3a9d81f0",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "73b05666_1fd8f56c",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 44,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "Made me smile but I wouldn\u0027t put this here 😊",
"range": {
"startLine": 44,
"startChar": 52,
"endLine": 44,
"endChar": 78
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "56a0e1b6_c6cf4111",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 44,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "73b05666_1fd8f56c",
"range": {
"startLine": 44,
"startChar": 52,
"endLine": 44,
"endChar": 78
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ab6cb80b_a2c409c5",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 51,
"author": {
"id": 27427
},
"writtenOn": "2021-06-23T13:02:30Z",
"side": 1,
"message": "heh, not loving the use of \u0027swallowed\u0027 here; also it might not be worth referencing downstream since the community can\u0027t see that and it appears meaningless :-)",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "a372ba57_09788d7b",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 51,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "+1 on this",
"parentUuid": "ab6cb80b_a2c409c5",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "09b355ea_829a57ca",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 51,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "a372ba57_09788d7b",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "2da820f9_0ca9d1ce",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 27419
},
"writtenOn": "2021-06-23T13:23:41Z",
"side": 1,
"message": "I\u0027d remove this line as it\u0027s expected that people will validate and re-read, otherwise we should include this line everywhere in our doc 😊",
"range": {
"startLine": 53,
"startChar": 0,
"endLine": 54,
"endChar": 59
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "98778d46_449ae1d7",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "2da820f9_0ca9d1ce",
"range": {
"startLine": 53,
"startChar": 0,
"endLine": 54,
"endChar": 59
},
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "37324ffe_f558385e",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 57,
"author": {
"id": 27427
},
"writtenOn": "2021-06-23T13:02:30Z",
"side": 1,
"message": "as per #51",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "62174c70_4b6d47cf",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 57,
"author": {
"id": 11491
},
"writtenOn": "2021-06-23T13:44:44Z",
"side": 1,
"message": "https://bugzilla.redhat.com/buglist.cgi?component\u003dvalidations-libs\u0026product\u003dRed%20Hat%20OpenStack is the wrong url because the component is called python-validations-libs and not validations-libs in bugzilla.",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "344d308d_70b6593c",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 57,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Ack",
"parentUuid": "37324ffe_f558385e",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "8c972b4e_a97232cb",
"filename": "doc/source/debugging.rst",
"patchSetId": 3
},
"lineNbr": 57,
"author": {
"id": 32926
},
"writtenOn": "2021-06-24T05:36:43Z",
"side": 1,
"message": "Done",
"parentUuid": "62174c70_4b6d47cf",
"revId": "b2e7a44220a973f347694f29324ca77bb7cb75fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink