74 lines
2.1 KiB
Plaintext
74 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "28c4940b_ce3c1408",
|
|
"filename": "validations_libs/cli/common.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 79,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2021-05-05T07:24:41Z",
|
|
"side": 1,
|
|
"message": "If you reverse this condition, and move the 83-99 block in it, you can achieve the same behavior without the continue.",
|
|
"revId": "72803791ed09015d33a96610d32ad3f384acd30a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "6d540ef8_2f84049b",
|
|
"filename": "validations_libs/cli/common.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 79,
|
|
"author": {
|
|
"id": 10459
|
|
},
|
|
"writtenOn": "2021-05-05T07:42:23Z",
|
|
"side": 1,
|
|
"message": "That\u0027s intentional: less indentation and clutter. But I can change it.",
|
|
"parentUuid": "28c4940b_ce3c1408",
|
|
"revId": "72803791ed09015d33a96610d32ad3f384acd30a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5c0b4f83_3b6ebb76",
|
|
"filename": "validations_libs/cli/common.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 85,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2021-05-05T07:24:41Z",
|
|
"side": 1,
|
|
"message": "If possible, you might want to try compiling the regex outside of the loop. It could speed things up somewhat.",
|
|
"revId": "72803791ed09015d33a96610d32ad3f384acd30a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "b3e9f6a7_932e0912",
|
|
"filename": "validations_libs/cli/common.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 85,
|
|
"author": {
|
|
"id": 10459
|
|
},
|
|
"writtenOn": "2021-05-05T07:42:23Z",
|
|
"side": 1,
|
|
"message": "Sure, I will fix it",
|
|
"parentUuid": "5c0b4f83_3b6ebb76",
|
|
"revId": "72803791ed09015d33a96610d32ad3f384acd30a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |