93 lines
2.9 KiB
Plaintext
93 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "1c51d0f9_33672087",
|
|
"filename": "validations_libs/cli/base.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 23,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2021-06-04T10:42:04Z",
|
|
"side": 1,
|
|
"message": "Couldn\u0027t we override this in the existing classes?",
|
|
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5e20d1f3_d92e662d",
|
|
"filename": "validations_libs/cli/base.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 23,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-06-04T11:48:46Z",
|
|
"side": 1,
|
|
"message": "Nop, Command class is used in several places in the CLI, plus, my work with the config file will re-used this base.py file.",
|
|
"parentUuid": "1c51d0f9_33672087",
|
|
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf32b441_cee3ca95",
|
|
"filename": "validations_libs/cli/base.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 23,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2021-06-04T12:12:26Z",
|
|
"side": 1,
|
|
"message": "I meant in the classes we already define in the validations_libs/cli. They are unique to us and used only in the VF.",
|
|
"parentUuid": "5e20d1f3_d92e662d",
|
|
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dab7795e_eef40d57",
|
|
"filename": "validations_libs/cli/base.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 23,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-06-04T12:18:59Z",
|
|
"side": 1,
|
|
"message": "Yep, I\u0027ve understood, but if this piece of code needs to be moved into run.py, it will be duplicated as well in history.py.\nSame for the lister, it will have to be duplicated in several places.\nIt serve actually a common role for all, eventually futur other cli implementations.",
|
|
"parentUuid": "bf32b441_cee3ca95",
|
|
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "a65f77ef_c649edfb",
|
|
"filename": "validations_libs/cli/base.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 23,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2021-06-04T12:24:53Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "dab7795e_eef40d57",
|
|
"revId": "29b147e431e101f4de82e01bc2634a08b290bde2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |