111 lines
4.5 KiB
Plaintext
111 lines
4.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "dc6597f5_25135dac",
|
|
"filename": "doc/requirements.txt",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2021-07-23T06:55:06Z",
|
|
"side": 1,
|
|
"message": "folks see https://review.opendev.org/c/openstack/tripleo-repos/+/799986 especially the commit message.\n\nwe can\u0027t depend on cliff like this because it isn\u0027t available in centos.",
|
|
"revId": "17f775c4af853a4cdeef95c1d414f4a060239f77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dd9bfad1_e59e6a1d",
|
|
"filename": "doc/requirements.txt",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2021-07-23T07:19:10Z",
|
|
"side": 1,
|
|
"message": "k, first of all I didn\u0027t notice this was for doc/requirements\nas just discussed with jpodivin you already have cliff in https://opendev.org/openstack/validations-libs/src/commit/9a594f70c98e60217a1bc6d4870774b6d4a57945/requirements.txt#L10 so clearly that is being satisfied from somewhere... otherwise we would have had broken jobs already.\n\nremoving my -1 for now...",
|
|
"parentUuid": "dc6597f5_25135dac",
|
|
"revId": "17f775c4af853a4cdeef95c1d414f4a060239f77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "4e5a19c8_25656ffa",
|
|
"filename": "doc/requirements.txt",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2021-07-23T07:27:07Z",
|
|
"side": 1,
|
|
"message": "k in the job here it looks like it is pulling in python3-cliff at \n\nhttps://9a504d3846d8605cd77d-462e76888179d96b05b951c4b3bdf8c0.ssl.cf5.rackcdn.com/801623/4/check/tripleo-ci-centos-8-standalone-validation-libs/2a20e92/logs/undercloud/var/log/dnf.log\n python3-cliff noarch 3.8.0-0.20210601125422.d562aae.el8 delorean-component-common 95 k",
|
|
"parentUuid": "dd9bfad1_e59e6a1d",
|
|
"revId": "17f775c4af853a4cdeef95c1d414f4a060239f77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "23e7b508_f0e36992",
|
|
"filename": "doc/requirements.txt",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2021-07-23T07:34:31Z",
|
|
"side": 1,
|
|
"message": "just to complete the story.. the reason we had to revert for tripleo-repos is because it is used first for setting up the repos so in *that* case we have to depend on centos repos for cliff..\n\nin the job here it is pulled in from delorean repo so it is OK.\n\nsorry for the noise and thanks for responding quickly jpodivin.",
|
|
"parentUuid": "4e5a19c8_25656ffa",
|
|
"revId": "17f775c4af853a4cdeef95c1d414f4a060239f77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "71ee45c7_b102398d",
|
|
"filename": "doc/requirements.txt",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 11491
|
|
},
|
|
"writtenOn": "2021-07-23T08:09:48Z",
|
|
"side": 1,
|
|
"message": "Marios,\n\nPython-tripleoclient depends on osc-lib which depends on cliff too. And the VF packages are installed as dependencies of python-tripleoclient. Tripleo-repos intervenes well before the installation of python-tripleoclient.\n\nSo we are safe here.",
|
|
"parentUuid": "23e7b508_f0e36992",
|
|
"revId": "17f775c4af853a4cdeef95c1d414f4a060239f77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5c5811d0_8e7bb20f",
|
|
"filename": "doc/requirements.txt",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2021-07-23T08:16:52Z",
|
|
"side": 1,
|
|
"message": "yes thanks i am fully aware of the tripleoclient dependency (and in that case cliff comes in via openstackclient). I was mistaken about the special case for tripleo-repos where we can\u0027t depend on anything other than base os repos for dependencies.\n\nthanks",
|
|
"parentUuid": "71ee45c7_b102398d",
|
|
"revId": "17f775c4af853a4cdeef95c1d414f4a060239f77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |