validations-libs/bef53bc2f63d85b7b8a85e4327db38065b78e9a6

{
  "comments": [
    {
      "key": {
        "uuid": "84fcad19_db63ff46",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 105,
      "author": {
        "id": 27427
      },
      "writtenOn": "2021-09-16T12:30:32Z",
      "side": 1,
      "message": "If I read this correctly, we have made this function generic for use as extra vars or skip list.\n\nGood idea.\n\nBut... is there any scope for naming collision / race condition if operator passes _both_ extra-vars _and_ skip-list files?",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "9f1573d3_57b4c374",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 105,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-09-27T06:53:49Z",
      "side": 1,
      "message": "This function really needs another test case, for the YAMLError.\nIf things go wrong here we might end up with incorrect or no validations executing.",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "855fcd30_7ca78eb6",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 105,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-09-29T06:39:38Z",
      "side": 1,
      "message": "It\u0027s a basic Yaml load function and the RunTimeError raise a comprehensive message.",
      "parentUuid": "9f1573d3_57b4c374",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "909489be_d4a1a8f8",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 105,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-09-29T06:51:32Z",
      "side": 1,
      "message": "It is yes. Unfortunately, the catch clause is not reached by any of our tests as of now. Contributing to the anomalously low (63%) coverage of the module.\n\nYes chances of bug showing up here are small, from top of my head just the application of arguments in the format method of the error msg. But not zero. \n\nOne of the existing test cases can be easily adapted to cover this.",
      "parentUuid": "855fcd30_7ca78eb6",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "59d764f0_3db4f545",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 106,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-09-27T06:53:49Z",
      "side": 1,
      "message": "Since you are already writing docsrings, specification of the argument and return value would be nice :).",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "a04d73ef_e8a12599",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 111,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-09-27T06:53:49Z",
      "side": 1,
      "message": "I think this should be expanded to cover common IO errors.",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "ae7901e5_9c7a198a",
        "filename": "validations_libs/cli/common.py",
        "patchSetId": 2
      },
      "lineNbr": 111,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-09-29T06:39:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "a04d73ef_e8a12599",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9e8c8f47_b193d796",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 2
      },
      "lineNbr": 468,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-09-16T11:23:00Z",
      "side": 1,
      "message": "With using the skiplist-example.yaml file: \n\n   (undercloud) [stack@undercloud ~]$ cat skiplist-example.yaml\n   check-ram:\n     hosts: all\n     reason: Wrong ram value\n     lp: https://lp.fake.net\n   check-cpu:\n     hosts: undercloud\n     reason: Unstable validation\n     lp: https://lp.fake.net\n\nI\u0027ve got this if I execute the prep group of validations:\n\n   https://paste.opendev.org/show/809362/\n\nThe check-ram validation is skipped as expected on all hosts but the check-cpu doesn\u0027t seem to be skipped on the Undercloud/localhost and we got a \u0027No Host Matched\u0027 instead. Don\u0027t think it\u0027s coming from your patch but we need to debug that.\n\nNow if I add the service-status validation to be skipped only for the overcloud-controller-0 host:\n\n  (undercloud) [stack@undercloud ~]$ cat skiplist-example.yaml\n  check-ram:\n    hosts: all\n    reason: Wrong ram value\n    lp: https://lp.fake.net\n  check-cpu:\n    hosts: localhost\n    reason: Unstable validation\n    lp: https://lp.fake.net\n  service-status:\n    hosts: overcloud-controller-0\n    reason: This is classified\n    lp: https://lp.fake.net\n\nand if I re-execute the same command:\n\n   https://paste.opendev.org/show/809363/\n\nYou can see that the service-status didn\u0027t run on the expected host, which is good!\nHowever, the log info only gives us the list of the validations which should be entirely skipped.\n\nWhat do we want to output here? I think we have to get a *quick and efficient* brainstorming about that. 😄",
      "revId": "bef53bc2f63d85b7b8a85e4327db38065b78e9a6",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}