39 lines
1.8 KiB
Plaintext
39 lines
1.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5845e56d_9f9960bf",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2022-05-09T14:01:57Z",
|
|
"side": 1,
|
|
"message": "The container has to be buikd and run as rootless. So that we don\u0027t create a security hole.\nIt would also be a good idea to factor out the container definition into a separate file.\n\nLast but not least, we need to patch distgit so that it ignores the container/ subtree during build. ",
|
|
"revId": "23a9a56448e2ff762987c0e4ff58a011210c5fff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b7ed98cf_10f92efd",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2022-05-12T12:22:19Z",
|
|
"side": 1,
|
|
"message": "I fixed the container permissions and patch validations-libs-distgit:\nhttps://review.rdoproject.org/r/c/openstack/validations-libs-distgit/+/42777\n\nFor the container file, imho keeping the file into the script is better for few reasons.\nThe main reason for me is that we dont have to take care of the presence of the file, the path, where it\u0027s located and also to avoid breach where the user or someone modify the Containerfile and then break the build.\nAlso, since it\u0027s a dynamic file, I dont see much objection to dump it dynamicaly from a string to the file system. It\u0027s simply a dynamic string that we move into a container file.",
|
|
"parentUuid": "5845e56d_9f9960bf",
|
|
"revId": "23a9a56448e2ff762987c0e4ff58a011210c5fff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |