validations-libs/c573f41dd48eef27c284e626fe6...

149 lines
5.4 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "e06153f1_433b6f73",
"filename": "validations_libs/constants.py",
"patchSetId": 4
},
"lineNbr": 27,
"author": {
"id": 28223
},
"writtenOn": "2021-05-03T11:10:17Z",
"side": 1,
"message": "maybe \"basedir\" means /var/log, ${HOME}/ or /tmp, and we just mkdir/add the \"validations\" suffix? That sounds reasonable?",
"range": {
"startLine": 27,
"startChar": 16,
"endLine": 27,
"endChar": 23
},
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "0d6a3172_888b46c6",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 39,
"author": {
"id": 16515
},
"writtenOn": "2021-05-03T13:07:20Z",
"side": 1,
"message": "I think you could use: os.path.split(), example:\n\u003e\u003e\u003e p \u003d \u0027/Users/mathieu/Projects\u0027\n\u003e\u003e\u003e os.path.split(p)\n(\u0027/Users/mathieu\u0027, \u0027Projects\u0027)",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "368b34c2_9b80150f",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 91,
"author": {
"id": 28223
},
"writtenOn": "2021-05-03T11:10:17Z",
"side": 1,
"message": "using \"basedir\" as it is, we should get the complete path here since makedirs creates the full tree",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "aaa2159b_8c877c8b",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 91,
"author": {
"id": 32926
},
"writtenOn": "2021-05-03T12:38:09Z",
"side": 1,
"message": "I\u0027m not certain I follow. Yes it is true that the makedirs will give us full tree base on the path supplied. Could you please elaborate on what you are recommending?",
"parentUuid": "368b34c2_9b80150f",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "efd239b0_c42ff826",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 92,
"author": {
"id": 28223
},
"writtenOn": "2021-05-03T11:10:17Z",
"side": 1,
"message": "with the new way we set things, I\u0027m wondering when we might hit this one? If /var/log/validations exists and we don\u0027t have write rights in it?",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b917d27b_55a17ef0",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 92,
"author": {
"id": 32926
},
"writtenOn": "2021-05-03T12:38:09Z",
"side": 1,
"message": "Yes that is a possibility. It did actually happen just a few weeks ago with bandini and prompted this patch. Turns out we were dealing with oooq install with somewhat unintuitive params.\n\nThere was a discussion about fixing it, so that it\u0027s no longer possible. But other avenues might arise. Therefore I would prefer if we could keep this check.",
"parentUuid": "efd239b0_c42ff826",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "32b312e1_83d578c3",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 99,
"author": {
"id": 28223
},
"writtenOn": "2021-05-03T11:10:17Z",
"side": 1,
"message": "Wondering if we shouldn\u0027t make the check in the constant.py directly - it would prevent code duplication in other calls imho. apparently, there\u0027s even a File.writable() available in python that should returns boolean.... ?",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "09170343_c52ff3ce",
"filename": "validations_libs/utils.py",
"patchSetId": 4
},
"lineNbr": 99,
"author": {
"id": 32926
},
"writtenOn": "2021-05-03T12:38:09Z",
"side": 1,
"message": "Sadly I wasn\u0027t able to determine exactly how is that method implemented. It seems to be left to objects themselves as far as I can tell. And sadly I\u0027m not familiar enough with cpython codebase to get any further.\nhttps://github.com/python/cpython/blob/master/Modules/_io/iobase.c#L450\nIn any case, the matter of writing logs is left to ansible. VF just ensures that there is a place to put them in.",
"parentUuid": "32b312e1_83d578c3",
"revId": "c573f41dd48eef27c284e626fe6f2ca11300a1ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}