50 lines
2.5 KiB
Plaintext
50 lines
2.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "dcc04b0a_49f96afc",
|
|
"filename": "validations_libs/utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 53,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-05-04T08:14:54Z",
|
|
"side": 1,
|
|
"message": "I think you make a confusion between logs and artifacts directory.\nLogs directory is the place where the callback will write Ansible outputs from the validation playbook:\n/var/log/validations/\u003cuuid\u003e.json\n\nArtifacts directory is the place where Ansible will dump the stdout, stderr, rc, console, command, ansible.cfg.. :\n/var/log/validations/artifacts/uuid/\n\nIf I understand correctly your change here, you want to address the \"/var/log/validations\" problematic, which could be non existent or wrong access rights.\n\nThe create_artifacts_dir() function is just here to take care of the \".../artifacts/uuid/\" but it assume that \"/var/log/validations\" (or whatever path) already exists and is correct.\n\n\nIf the CI job doesn\u0027t grab the logs, it\u0027s because you replace:\n\".../artifacts/uuid\"\nby:\n\"../log/validations\"\nAnd the CI is expected to find an artifacts dir:\n\u0027/home/zuul/log/validations/169817bc-658d-4471-a895-d1dad8f13c58_check-cpu.yaml_2021-05-03T14:19:10.924418Z\u0027\n\nSo we should keep the \"../artifacts/\" dir name, because it\u0027s Ansible datas and Ansible Runner needs it.\n\nImho, to address the issue of the log directory, it should be something outside of this function and, if it could be sharable with the callback \"validation_json.py\", it will be really great. Then validations-libs.something will return the correct path for the VF and the callback.",
|
|
"range": {
|
|
"startLine": 53,
|
|
"startChar": 4,
|
|
"endLine": 53,
|
|
"endChar": 50
|
|
},
|
|
"revId": "e4dd69ec7cfbd4d55565177e6b926fbb83104f25",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7efa889a_78d3ed1f",
|
|
"filename": "validations_libs/utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 100,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-05-04T08:14:54Z",
|
|
"side": 1,
|
|
"message": "should be artifacts not log/validations.",
|
|
"range": {
|
|
"startLine": 100,
|
|
"startChar": 57,
|
|
"endLine": 100,
|
|
"endChar": 74
|
|
},
|
|
"revId": "e4dd69ec7cfbd4d55565177e6b926fbb83104f25",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |