validations-libs/facec585e51b5d8659475ff80112453f413c15a2

{
  "comments": [
    {
      "key": {
        "uuid": "50993376_bf97df7e",
        "filename": "config_demo.cfg",
        "patchSetId": 17
      },
      "lineNbr": 35,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-25T19:57:35Z",
      "side": 1,
      "message": "Hmm, I don\u0027t think we should manage the extra variables here in the configuration file.\n\nSome validations have serious and complex data structures for their variables. Listing them here with the dict format in a INI file is overkill IMO!\n\nThis should be a configuration file for the CLI internals, not for the validations themselves...",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "c23ffe68_be42e5c2",
        "filename": "config_demo.cfg",
        "patchSetId": 17
      },
      "lineNbr": 55,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-25T19:57:35Z",
      "side": 1,
      "message": "Can\u0027t we use a real ansible.cfg file for all of those keys?",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "86da132a_df8f455a",
        "filename": "config_demo.cfg",
        "patchSetId": 17
      },
      "lineNbr": 55,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-05-25T20:29:54Z",
      "side": 1,
      "message": "Why two config files ?\nvalidation.cfg is an ansible.cfg extended to the framework, but as the VF is a wrapper on Ansible, I think handling only 1 file is sane.",
      "parentUuid": "c23ffe68_be42e5c2",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "03202d44_1b584ef8",
        "filename": "validations_libs/ansible.py",
        "patchSetId": 17
      },
      "lineNbr": 279,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "It might be a good idea to place this in the utils.py module.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "2ca77245_37399820",
        "filename": "validations_libs/ansible.py",
        "patchSetId": 17
      },
      "lineNbr": 477,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "No need for the \u0027keys()\u0027.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "e970e697_fb4da7d4",
        "filename": "validations_libs/ansible.py",
        "patchSetId": 17
      },
      "lineNbr": 480,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "Why move this here from 437?\nIf the config check was moved before the BACKWARD_COMPAT check, we could avoid the condition.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "ddf1d6b3_d8a355d7",
        "filename": "validations_libs/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 337,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "This can be used to execute arbitrary expressions. Potentially causing great deal of damage.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "57a52751_a64f5d9c",
        "filename": "validations_libs/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 361,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "No need for keys() here.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "5d7fe30a_350c523f",
        "filename": "validations_libs/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 373,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "Warning should be raised here about invalid parameter.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "43d1a24a_48806271",
        "filename": "validations_libs/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 380,
      "author": {
        "id": 32926
      },
      "writtenOn": "2021-05-25T14:31:01Z",
      "side": 1,
      "message": "Warning would be more fitting then info. As this does compromise functionality.",
      "revId": "facec585e51b5d8659475ff80112453f413c15a2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}