validations-libs/2b50ae5bab3fbe573afef6ba9323d235fb76f5b3

{
  "comments": [
    {
      "key": {
        "uuid": "27b74d33_411c55f9",
        "filename": "/COMMIT_MSG",
        "patchSetId": 21
      },
      "lineNbr": 10,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/include/includes/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "baf60678_4d29d409",
        "filename": "/COMMIT_MSG",
        "patchSetId": 21
      },
      "lineNbr": 11,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/referece/reference/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "aedb5240_3fdbeb60",
        "filename": "/COMMIT_MSG",
        "patchSetId": 21
      },
      "lineNbr": 13,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/contain/contains/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "0574cacb_dd140e9e",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 35,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-05-05T06:27:15Z",
      "side": 1,
      "message": "You should drop this function, which doesn\u0027t really make sense.\nIf we want to check the presence of /tmp in the path, we dont need a specific function for it",
      "range": {
        "startLine": 35,
        "startChar": 0,
        "endLine": 35,
        "endChar": 29
      },
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "1d7a5be8_4c3b44be",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 41,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/folder.\"/folder. \"/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "c75a5c31_a5c49df4",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 42,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/volatile\"/volatile \"/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "7f7e99b1_869c2b4a",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 43,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/\" location/\"location/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "68919551_43acc43f",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 44,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "s/valiations/validations/\ns/fallback.\"/fallback. \"/",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "3b0fab81_d28d1c75",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 50,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-05-05T06:27:15Z",
      "side": 1,
      "message": "If we assume that now the default directory for the log is:\n$HOME/validations\n\nthen this function should just:\n1/ check if this path is present\n2/ if it\u0027s writable\n3/ if not present try to create it.",
      "range": {
        "startLine": 50,
        "startChar": 0,
        "endLine": 50,
        "endChar": 29
      },
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "dd18c49c_f8a7bc5f",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 89,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-05-05T06:27:15Z",
      "side": 1,
      "message": "You should revert to the master code here.\nYou are doing almost the same behavior.",
      "range": {
        "startLine": 89,
        "startChar": 4,
        "endLine": 89,
        "endChar": 43
      },
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "d2c95393_485f3b57",
        "filename": "validations_libs/utils.py",
        "patchSetId": 21
      },
      "lineNbr": 145,
      "author": {
        "id": 16515
      },
      "writtenOn": "2021-05-05T06:27:15Z",
      "side": 1,
      "message": "this should be done in one place, only one time, otherwise you will get race where in some case it will fallback to tmp and some other not.",
      "range": {
        "startLine": 145,
        "startChar": 18,
        "endLine": 145,
        "endChar": 77
      },
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "68e931c0_d3968e97",
        "filename": "validations_libs/validation_actions.py",
        "patchSetId": 21
      },
      "lineNbr": 215,
      "author": {
        "id": 11491
      },
      "writtenOn": "2021-05-04T19:48:49Z",
      "side": 1,
      "message": "Why defaulting to validation_json?",
      "revId": "2b50ae5bab3fbe573afef6ba9323d235fb76f5b3",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}