97 lines
2.9 KiB
Plaintext
97 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "11d36b51_67ad58d8",
|
|
"filename": "validations_libs/utils.py",
|
|
"patchSetId": 26
|
|
},
|
|
"lineNbr": 72,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-05-05T13:44:28Z",
|
|
"side": 1,
|
|
"message": "I think the missing part here is the check to see if the log_path provided by the caller is writable.",
|
|
"range": {
|
|
"startLine": 52,
|
|
"startChar": 0,
|
|
"endLine": 72,
|
|
"endChar": 19
|
|
},
|
|
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "db5f73f3_1f3ea90c",
|
|
"filename": "validations_libs/utils.py",
|
|
"patchSetId": 26
|
|
},
|
|
"lineNbr": 104,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-05-05T13:44:28Z",
|
|
"side": 1,
|
|
"message": "no log/validations but /validations/ right ?\nand no more /tmp ?",
|
|
"range": {
|
|
"startLine": 102,
|
|
"startChar": 1,
|
|
"endLine": 104,
|
|
"endChar": 0
|
|
},
|
|
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "0c1fca9f_3f54e9d7",
|
|
"filename": "validations_libs/utils.py",
|
|
"patchSetId": 26
|
|
},
|
|
"lineNbr": 104,
|
|
"author": {
|
|
"id": 32926
|
|
},
|
|
"writtenOn": "2021-05-10T08:44:44Z",
|
|
"side": 1,
|
|
"message": "No point in fixing docstrings until The thing actually works. Which might take a while.\n\nBut in general terms, most of this will have go.",
|
|
"parentUuid": "db5f73f3_1f3ea90c",
|
|
"range": {
|
|
"startLine": 102,
|
|
"startChar": 1,
|
|
"endLine": 104,
|
|
"endChar": 0
|
|
},
|
|
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7c8601a2_2d780391",
|
|
"filename": "validations_libs/utils.py",
|
|
"patchSetId": 26
|
|
},
|
|
"lineNbr": 139,
|
|
"author": {
|
|
"id": 16515
|
|
},
|
|
"writtenOn": "2021-05-05T13:44:28Z",
|
|
"side": 1,
|
|
"message": "and here, at this stage, we assume that the place where the \"artifacts\" directory will be created is sane and writable, so no need to check or default anything.\n\nAnd mainly because, if this dir can not be created, the callback wont be able to write in the log path.\n\nSo every logic to check if log path is correct should happen before.\n\nI suggest to revert to the original function for this part.",
|
|
"range": {
|
|
"startLine": 117,
|
|
"startChar": 0,
|
|
"endLine": 139,
|
|
"endChar": 41
|
|
},
|
|
"revId": "27844cdcea0069a4fee7dcfa828dd011b63d52d1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |