diff --git a/test-requirements.txt b/test-requirements.txt index e705ad4..b91cde7 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -6,6 +6,7 @@ hacking>=3.0.0,<3.1.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0 doc8>=0.6.0 # Apache-2.0 +flake8-import-order>=0.13 # LGPLv3 python-subunit>=1.0.0 # Apache-2.0/BSD sphinx!=1.6.6,!=1.6.7,!=2.1.0,>=1.6.2 # BSD openstackdocstheme>=1.20.0 # Apache-2.0 diff --git a/tox.ini b/tox.ini index c60997d..118f279 100644 --- a/tox.ini +++ b/tox.ini @@ -57,6 +57,9 @@ commands = oslo_debug_helper {posargs} # [E129] Visually indented line with same indent as next logical line. # [W503] Line break occurred before a binary operator. Conflicts with W504. ignore = E129,W503 +filename = *.py +import-order-style = pep8 +application-import-names = virtualbmc exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build max-complexity=17 diff --git a/virtualbmc/cmd/vbmc.py b/virtualbmc/cmd/vbmc.py index be3e78c..e9bcc4e 100644 --- a/virtualbmc/cmd/vbmc.py +++ b/virtualbmc/cmd/vbmc.py @@ -18,7 +18,6 @@ from cliff.app import App from cliff.command import Command from cliff.commandmanager import CommandManager from cliff.lister import Lister - import zmq import virtualbmc diff --git a/virtualbmc/tests/unit/test_control.py b/virtualbmc/tests/unit/test_control.py index a588a53..40e7fa3 100644 --- a/virtualbmc/tests/unit/test_control.py +++ b/virtualbmc/tests/unit/test_control.py @@ -17,7 +17,6 @@ import json import os from unittest import mock - import zmq from virtualbmc import control diff --git a/virtualbmc/tests/unit/test_vbmc.py b/virtualbmc/tests/unit/test_vbmc.py index cf4c2eb..5f2a2f6 100644 --- a/virtualbmc/tests/unit/test_vbmc.py +++ b/virtualbmc/tests/unit/test_vbmc.py @@ -13,9 +13,10 @@ # License for the specific language governing permissions and limitations # under the License. -import libvirt from unittest import mock +import libvirt + from virtualbmc import exception from virtualbmc.tests.unit import base from virtualbmc.tests.unit import utils as test_utils