openstack
/
virtualbmc
Code Issues Proposed changes

Restore pep8 checking on import order 

Currently not checking import orders, this patch restore it.

Change-Id: I101814591eaffb694a090aa640ca9ac70db2ecf1
This commit is contained in:
Kaifeng Wang 2020-04-20 11:35:00 +08:00 committed by Riccardo Pittau
parent adf6950549
commit 132fe3ce24
5 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test-requirements.txt
View File

@ -6,6 +6,7 @@ hacking>=3.0.0,<3.1.0 # Apache-2.0
coverage!=4.4,>=4.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0
doc8>=0.6.0 # Apache-2.0 doc8>=0.6.0 # Apache-2.0
flake8-import-order>=0.13 # LGPLv3
python-subunit>=1.0.0 # Apache-2.0/BSD python-subunit>=1.0.0 # Apache-2.0/BSD
sphinx!=1.6.6,!=1.6.7,!=2.1.0,>=1.6.2 # BSD sphinx!=1.6.6,!=1.6.7,!=2.1.0,>=1.6.2 # BSD
openstackdocstheme>=1.20.0 # Apache-2.0 openstackdocstheme>=1.20.0 # Apache-2.0

3
tox.ini
View File

@ -57,6 +57,9 @@ commands = oslo_debug_helper {posargs}
# [E129] Visually indented line with same indent as next logical line. # [E129] Visually indented line with same indent as next logical line.
# [W503] Line break occurred before a binary operator. Conflicts with W504. # [W503] Line break occurred before a binary operator. Conflicts with W504.
ignore = E129,W503 ignore = E129,W503
filename = *.py
import-order-style = pep8
application-import-names = virtualbmc
exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build
max-complexity=17 max-complexity=17

1
virtualbmc/cmd/vbmc.py
View File

@ -18,7 +18,6 @@ from cliff.app import App
from cliff.command import Command from cliff.command import Command
from cliff.commandmanager import CommandManager from cliff.commandmanager import CommandManager
from cliff.lister import Lister from cliff.lister import Lister
import zmq import zmq
import virtualbmc import virtualbmc

1
virtualbmc/tests/unit/test_control.py
View File

@ -17,7 +17,6 @@ import json
import os import os
from unittest import mock from unittest import mock
import zmq import zmq
from virtualbmc import control from virtualbmc import control

3
virtualbmc/tests/unit/test_vbmc.py
View File

@ -13,9 +13,10 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
import libvirt
from unittest import mock from unittest import mock
import libvirt
from virtualbmc import exception from virtualbmc import exception
from virtualbmc.tests.unit import base from virtualbmc.tests.unit import base
from virtualbmc.tests.unit import utils as test_utils from virtualbmc.tests.unit import utils as test_utils