openstack/vitrage-tempest-plugin
Code Issues Proposed changes

Use vars() more readable then __dict__

Browse Source 
Change-Id: Ibf32b59f078c4258d01c298068507d7fa22a9715
This commit is contained in:
Eyal 2020-06-28 15:24:35 +03:00
parent 27feeadf4b
commit 161a59e274
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vitrage_tempest_plugin/tests/common/cinder_utils.py
View File

@ -47,6 +47,6 @@ def _check_num_volumes(num_volumes=0, state=''):
if len(TempestClients.cinder().volumes.list()) != num_volumes: if len(TempestClients.cinder().volumes.list()) != num_volumes:
return False return False
return all(volume.__dict__['status'].upper() == state.upper() and return all(vars(volume)['status'].upper() == state.upper() and
len(volume.__dict__['attachments']) == 1 len(vars(volume)['attachments']) == 1
for volume in TempestClients.cinder().volumes.list()) for volume in TempestClients.cinder().volumes.list())

2
vitrage_tempest_plugin/tests/common/general_utils.py
View File

@ -32,7 +32,7 @@ def is_subset(subset, full):
return True return True
full_dict = full full_dict = full
if type(full) is not dict: if type(full) is not dict:
full_dict = full.__dict__ full_dict = vars(full)
return six.viewitems(subset) <= six.viewitems(full_dict) return six.viewitems(subset) <= six.viewitems(full_dict)